[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [RFC PATCH 0/2] ide/ahci: add missing includes
From: |
Philippe Mathieu-Daudé |
Subject: |
[Qemu-block] [RFC PATCH 0/2] ide/ahci: add missing includes |
Date: |
Fri, 9 Jun 2017 12:05:58 -0300 |
Hi Eric, John.
The patch 07/11 "hw/arm: use defined type name instead of hard-coded string."
triggered this problem.
I split the previous series to only include the 2 commits involved to reproduce.
As you will see, calxeda_init() from highbank.c uses the sysbus type name
"sysbus-ahci" which is already defined in "hw/ide/ahci.h" as TYPE_SYSBUS_AHCI.
As mentioned in HACKING highbank.c first include is "qemu/osdep.h". However
compiling highbank.c fails (as reported in patch "04/11" commit comments).
I don't think appropriate to include "hw/ide/internal.h" and "sysemu/dma.h" in
highbank.c. Eventually another source including "hw/ide/ahci.h" will hit the
same error.
Do you see another place where those includes should go?
I think I did a mistake sending these both patchs in a series thinking they were
unrelated, I should have send them altogether, my bad :/
Regards,
Phil.
Philippe Mathieu-Daudé (2):
arm/highbank: use defined type name instead of hard-coded string
ide/ahci: add missing includes
hw/arm/highbank.c | 3 ++-
include/hw/ide/ahci.h | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
--
2.11.0
- [Qemu-block] [RFC PATCH 0/2] ide/ahci: add missing includes,
Philippe Mathieu-Daudé <=
- Message not available