qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH v5 5/5] iotests: chown LUKS device before qemu-i


From: Max Reitz
Subject: Re: [Qemu-block] [PATCH v5 5/5] iotests: chown LUKS device before qemu-io launches
Date: Wed, 31 May 2017 18:15:27 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0

On 2017-05-09 19:33, Daniel P. Berrange wrote:
> On some distros, whenever you close a block device file
> descriptor there is a udev rule that resets the file
> permissions. This can race with the test script when
> we run qemu-io multiple times against the same block
> device. Occasionally the second qemu-io invocation
> will find udev has reset the permissions causing failure.
> 
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>  tests/qemu-iotests/149     |  13 +-
>  tests/qemu-iotests/149.out | 344 
> ++++++++++++++++++++++-----------------------
>  2 files changed, 178 insertions(+), 179 deletions(-)
> 
> diff --git a/tests/qemu-iotests/149 b/tests/qemu-iotests/149
> index 5faf585..bc628ce 100755
> --- a/tests/qemu-iotests/149
> +++ b/tests/qemu-iotests/149
> @@ -23,6 +23,7 @@
>  import subprocess
>  import os
>  import os.path
> +import time

Why?

Rest looks good.

Max

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]