[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH 01/11] qcow2: call CoQueue APIs und
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH 01/11] qcow2: call CoQueue APIs under CoMutex |
Date: |
Wed, 31 May 2017 10:18:24 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 05/31/2017 04:43 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> block/qcow2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 1c2697732b..c9193603b9 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -1696,8 +1696,6 @@ static coroutine_fn int
> qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,
> ret = 0;
>
> fail:
> - qemu_co_mutex_unlock(&s->lock);
> -
> while (l2meta != NULL) {
> QCowL2Meta *next;
>
> @@ -1711,6 +1709,8 @@ fail:
> l2meta = next;
> }
>
> + qemu_co_mutex_unlock(&s->lock);
> +
> qemu_iovec_destroy(&hd_qiov);
> qemu_vfree(cluster_data);
> trace_qcow2_writev_done_req(qemu_coroutine_self(), ret);
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [RFC PATCH 00/11] Block layer thread-safety, part 2, Paolo Bonzini, 2017/05/31
- [Qemu-block] [PATCH 01/11] qcow2: call CoQueue APIs under CoMutex, Paolo Bonzini, 2017/05/31
- Re: [Qemu-block] [Qemu-devel] [PATCH 01/11] qcow2: call CoQueue APIs under CoMutex,
Eric Blake <=
- [Qemu-block] [PATCH 03/11] vdi: make it thread-safe, Paolo Bonzini, 2017/05/31
- [Qemu-block] [PATCH 02/11] coroutine-lock: add qemu_co_rwlock_downgrade and qemu_co_rwlock_upgrade, Paolo Bonzini, 2017/05/31
- [Qemu-block] [PATCH 04/11] vpc: make it thread-safe, Paolo Bonzini, 2017/05/31
- [Qemu-block] [PATCH 05/11] vvfat: make it thread-safe, Paolo Bonzini, 2017/05/31
- [Qemu-block] [PATCH 06/11] nbd: make it thread-safe, Paolo Bonzini, 2017/05/31