Re: [Qemu-block] [RFC] Making 'block-stream', and 'block-commit' accept node-name

[Kashyap Chamarthy]

On Tue, May 30, 2017 at 04:53:23PM +0200, Alberto Garcia wrote:
> On Mon 29 May 2017 09:03:22 PM CEST, Kashyap Chamarthy wrote:
> 
> > Observe the following ('qmp-shell', for brevity) invocation of the
> > four major types (stream, commit, mirror, backup) of live block
> > operations:
> >
> >     (QEMU) block-stream device=node-D base=a.qcow2 job-id=job-block-stream
> >     (QEMU) block-commit device=node-D base=a.qcow2 top=b.qcow2 
> > job-id=job-block-commit
> >     (QEMU) drive-mirror device=node-D target=e.qcow2 sync=full 
> > job-id=job-drive-mirror
> >     (QEMU) drive-backup device=node-D sync=full target=e.qcow2 
> > job-id=job-drive-backup
> >     (QEMU) blockdev-backup device=node-B target=node-E sync=full 
> > job-id=job-blockdev-backup
> >     (QEMU) blockdev-mirror device=node-D target=node-E sync=full 
> > job-id=job-blockdev-mirror
> >
> > While we have `blockdev-{mirror, backup}` as 'node-name'-alternatives
> > for `drive-{mirror, backup}`, as the eagle-eyed will, the
> > `block-stream` and `block-commit` commands still operate on file names
> > for parameters 'base' and 'top'.
> 
> block-stream does accept a node name for the top and base images (see
> 554b614765090f47d and 312fe09cc8af86c).

Ah, I didn't realize `block-stream` accepts 'node-name' for 'base' and
'top'.  Thanks for the pointers.

But still, I wonder, for consistency's sake: will a new
`blockdev-{stream, commit}` ever be created.

> block-commit hasn't changed, but it should be possible to follow a
> similar approach.

Noted.

[...]

-- 
/kashyap