[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 12/18] block: access write_gen with atomics
From: |
Paolo Bonzini |
Subject: |
[Qemu-block] [PATCH 12/18] block: access write_gen with atomics |
Date: |
Thu, 25 May 2017 18:32:19 +0200 |
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
block.c | 2 +-
block/io.c | 6 +++---
include/block/block_int.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index f6066ef..45a77f5 100644
--- a/block.c
+++ b/block.c
@@ -3384,7 +3384,7 @@ int bdrv_truncate(BdrvChild *child, int64_t offset, Error
**errp)
ret = refresh_total_sectors(bs, offset >> BDRV_SECTOR_BITS);
bdrv_dirty_bitmap_truncate(bs);
bdrv_parent_cb_resize(bs);
- ++bs->write_gen;
+ atomic_inc(&bs->write_gen);
}
return ret;
}
diff --git a/block/io.c b/block/io.c
index afb8294..8021b5b 100644
--- a/block/io.c
+++ b/block/io.c
@@ -1415,7 +1415,7 @@ static int coroutine_fn bdrv_aligned_pwritev(BdrvChild
*child,
}
bdrv_debug_event(bs, BLKDBG_PWRITEV_DONE);
- ++bs->write_gen;
+ atomic_inc(&bs->write_gen);
bdrv_set_dirty(bs, start_sector, end_sector - start_sector);
stat64_max(&bs->wr_highest_offset, offset + bytes);
@@ -2304,7 +2304,7 @@ int coroutine_fn bdrv_co_flush(BlockDriverState *bs)
goto early_exit;
}
- current_gen = bs->write_gen;
+ current_gen = atomic_read(&bs->write_gen);
/* Wait until any previous flushes are completed */
while (bs->active_flush_req) {
@@ -2529,7 +2529,7 @@ int coroutine_fn bdrv_co_pdiscard(BlockDriverState *bs,
int64_t offset,
}
ret = 0;
out:
- ++bs->write_gen;
+ atomic_inc(&bs->write_gen);
bdrv_set_dirty(bs, req.offset >> BDRV_SECTOR_BITS,
req.bytes >> BDRV_SECTOR_BITS);
tracked_request_end(&req);
diff --git a/include/block/block_int.h b/include/block/block_int.h
index a23e4bb..74d6e62 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -612,7 +612,6 @@ struct BlockDriverState {
QLIST_HEAD(, BdrvTrackedRequest) tracked_requests;
CoQueue flush_queue; /* Serializing flush queue */
bool active_flush_req; /* Flush request in flight? */
- unsigned int write_gen; /* Current data generation */
unsigned int flushed_gen; /* Flushed write generation */
QLIST_HEAD(, BdrvDirtyBitmap) dirty_bitmaps;
@@ -647,6 +646,7 @@ struct BlockDriverState {
/* Accessed with atomic ops. */
int quiesce_counter;
+ unsigned int write_gen; /* Current data generation */
};
struct BlockBackendRootState {
--
1.8.3.1
- [Qemu-block] [PATCH 03/18] block: access io_limits_disabled with atomic ops, (continued)
- [Qemu-block] [PATCH 03/18] block: access io_limits_disabled with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 06/18] block: access io_plugged with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 01/18] block: access copy_on_read with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 02/18] block: access quiesce_counter with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 05/18] block: access wakeup with atomic ops, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 07/18] throttle-groups: only start one coroutine from drained_begin, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 08/18] throttle-groups: do not use qemu_co_enter_next, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 09/18] throttle-groups: protect throttled requests with a CoMutex, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 10/18] util: add stats64 module, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 11/18] block: use Stat64 for wr_highest_offset, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 12/18] block: access write_gen with atomics,
Paolo Bonzini <=
- [Qemu-block] [PATCH 13/18] block: protect tracked_requests and flush_queue with reqs_lock, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 14/18] block: introduce dirty_bitmap_mutex, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 15/18] migration/block: reset dirty bitmap before reading, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 17/18] block: introduce block_account_one_io, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 16/18] block: protect modification of dirty bitmaps with a mutex, Paolo Bonzini, 2017/05/25
- [Qemu-block] [PATCH 18/18] block: make accounting thread-safe, Paolo Bonzini, 2017/05/25
- Re: [Qemu-block] [Qemu-devel] [PATCH v3 00/18] Block layer thread safety, part 1, no-reply, 2017/05/25
- Re: [Qemu-block] [PATCH v3 00/18] Block layer thread safety, part 1, Fam Zheng, 2017/05/25