qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH 03/13] vvfat: fix typos


From: Hervé Poussineau
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH 03/13] vvfat: fix typos
Date: Wed, 17 May 2017 07:15:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

Le 16/05/2017 à 15:21, Kevin Wolf a écrit :
Am 15.05.2017 um 22:31 hat Hervé Poussineau geschrieben:
@@ -806,7 +806,7 @@ static int read_directory(BDRVVVFATState* s, int 
mapping_index)
                 (ROOT_ENTRIES - cur) * sizeof(direntry_t));
     }

-     /* reget the mapping, since s->mapping was possibly realloc()ed */
+    /* reset the mapping, since s->mapping was possibly realloc()ed */

Are you sure that this was a typo? It seems to make more sense to me as
"re-get" (maybe easer to read with the hyphen).

IMO, both are valid. But I'll change it to "re-get" for v2.


     mapping = array_get(&(s->mapping), mapping_index);
     first_cluster += (s->directory.next - mapping->info.dir.first_dir_index)
         * 0x20 / s->cluster_size;

Kevin





reply via email to

[Prev in Thread] Current Thread [Next in Thread]