[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 05/11] blockjob: separate monitor and blockjob A
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-block] [PATCH 05/11] blockjob: separate monitor and blockjob APIs |
|
Date: |
Tue, 9 May 2017 19:09:23 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 09/05/2017 19:06, Jeff Cody wrote:
>> Keep the two APIs separate in the blockjob.c file too. This will
>> be useful when transitioning away from the AioContext lock, because
>> there will be locking policies for the two categories, too---the
>> monitor will have to call new block_job_lock/unlock APIs, while blockjob
>> APIs will take care of this for the users.
>
> Would it make sense to split this out into separate files, rather than
> delineating it by placement in a single .c file?
Probably not, because the latter APIs do use several static functions in
blockjob.c. For example, block_job_early_fail calls block_job_unref,
block_job_completed calls block_job_finish_sync (via
block_job_completed_txn_abort).
Given the file is <1000 lines of code, I think it's not worth the hassle.
Paolo
- [Qemu-block] [PATCH 01/11] blockjob: remove unnecessary check, (continued)
- [Qemu-block] [PATCH 01/11] blockjob: remove unnecessary check, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 02/11] blockjob: remove iostatus_reset callback, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 03/11] blockjob: introduce block_job_early_fail, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 04/11] blockjob: introduce block_job_pause/resume_all, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 05/11] blockjob: separate monitor and blockjob APIs, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 06/11] blockjob: move iostatus reset inside block_job_user_resume, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 07/11] blockjob: introduce block_job_cancel_async, check iostatus invariants, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 08/11] blockjob: group BlockJob transaction functions together, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 10/11] blockjob: reorganize block_job_completed_txn_abort, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 11/11] blockjob: use deferred_to_main_loop to indicate the coroutine has ended, Paolo Bonzini, 2017/05/08
- [Qemu-block] [PATCH 09/11] blockjob: strengthen a bit test-blockjob-txn, Paolo Bonzini, 2017/05/08
- Re: [Qemu-block] [PATCH v2 00/11] Preparation for block job mutex, Paolo Bonzini, 2017/05/21
- Re: [Qemu-block] [PATCH v2 00/11] Preparation for block job mutex, Jeff Cody, 2017/05/22