[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v10 04/17] qcow2: Optimize zero_single_l2() to m
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v10 04/17] qcow2: Optimize zero_single_l2() to minimize L2 churn |
Date: |
Fri, 28 Apr 2017 14:11:48 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/28/2017 01:00 PM, Max Reitz wrote:
> On 27.04.2017 03:46, Eric Blake wrote:
>> Similar to discard_single_l2(), we should try to avoid dirtying
>> the L2 cache when the cluster we are changing already has the
>> right characteristics.
>>
>> - /* Update L2 entries */
>> + /*
>> + * Minimize L2 changes if the cluster already reads back as
>> + * zeroes with correct allocation.
>> + */
>> + if (qcow2_get_cluster_type(old_offset) == QCOW2_CLUSTER_ZERO &&
>> + !(unmap && old_offset & L2E_OFFSET_MASK)) {
>> + continue;
>> + }
>> +
>> qcow2_cache_entry_mark_dirty(bs, s->l2_table_cache, l2_table);
>> - if (old_offset & QCOW_OFLAG_COMPRESSED || flags &
>> BDRV_REQ_MAY_UNMAP) {
>> + if (old_offset & QCOW_OFLAG_COMPRESSED || unmap) {
>
> Works, but I'd like it better to store the cluster type somewhere and
> then use it here instead of checking the COMPRESSED flag.
Indeed, qcow2_get_cluster_type() checks QCOW_OFLAG_COMPRESSED first -
but I like the idea of storing it in a temporary variable now that we
are using the cluster type in more than one place.
>
> But it works, so it's up to you:
>
> Reviewed-by: Max Reitz <address@hidden>
>
>> l2_table[l2_index + i] = cpu_to_be64(QCOW_OFLAG_ZERO);
>> qcow2_free_any_clusters(bs, old_offset, 1,
>> QCOW2_DISCARD_REQUEST);
>> } else {
>>
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v10 02/17] qcow2: Correctly report status of preallocated zero clusters, (continued)
- [Qemu-block] [PATCH v10 02/17] qcow2: Correctly report status of preallocated zero clusters, Eric Blake, 2017/04/26
- [Qemu-block] [PATCH v10 01/17] block: Update comments on BDRV_BLOCK_* meanings, Eric Blake, 2017/04/26
- [Qemu-block] [PATCH v10 03/17] qcow2: Reuse preallocated zero clusters, Eric Blake, 2017/04/26
- [Qemu-block] [PATCH v10 04/17] qcow2: Optimize zero_single_l2() to minimize L2 churn, Eric Blake, 2017/04/26
- [Qemu-block] [PATCH v10 06/17] qemu-io: Don't open-code QEMU_IS_ALIGNED, Eric Blake, 2017/04/26
- [Qemu-block] [PATCH v10 05/17] iotests: Add test 179 to cover write zeroes with unmap, Eric Blake, 2017/04/26
- [Qemu-block] [PATCH v10 07/17] qemu-io: Switch 'alloc' command to byte-based length, Eric Blake, 2017/04/26