[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu mus
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit |
Date: |
Tue, 18 Apr 2017 13:44:43 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0 |
On 04/18/2017 12:45 PM, Jeff Cody wrote:
> For the tests that use the common.qemu functions for running a QEMU
> process, _cleanup_qemu must be called in the exit function.
>
> If it is not, if the qemu process aborts, then not all of the droppings
> are cleaned up (e.g. pidfile, fifos).
>
> This updates those tests that did not have a cleanup in qemu-iotests.
>
> (I swapped spaces for tabs in test 102 as well)
>
> Reported-by: Eric Blake <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>
> v2 fixed typo in test 094, s/cleanup/_cleanup/ for the trap function.
>
> tests/qemu-iotests/028 | 1 +
> tests/qemu-iotests/094 | 11 ++++++++---
> tests/qemu-iotests/102 | 5 +++--
> tests/qemu-iotests/109 | 1 +
> tests/qemu-iotests/117 | 1 +
> tests/qemu-iotests/130 | 1 +
> tests/qemu-iotests/140 | 1 +
> tests/qemu-iotests/141 | 1 +
> tests/qemu-iotests/143 | 1 +
> 9 files changed, 18 insertions(+), 5 deletions(-)
Looks like you missed (at least?) 063
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit, Jeff Cody, 2017/04/18
- Re: [Qemu-block] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit,
Eric Blake <=
- Re: [Qemu-block] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit, Jeff Cody, 2017/04/18
- Re: [Qemu-block] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit, Eric Blake, 2017/04/18
- Re: [Qemu-block] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit, Jeff Cody, 2017/04/18
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit, Fam Zheng, 2017/04/19
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit, Max Reitz, 2017/04/19
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit, Jeff Cody, 2017/04/19
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 for-2.10 1/1] qemu-iotests: _cleanup_qemu must be called on exit, Max Reitz, 2017/04/19