Re: [Qemu-block] [PATCH 2/3] qemu-iotests: Filter HMP readline escape characters

[Eric Blake]

On 04/13/2017 12:23 PM, Kevin Wolf wrote:
> The only thing the escape characters achieve is making the reference
> output unreadable and lines that are potentially so long that git
> doesn't want to put them into an email any more. Let's filter them out.

Hear! Hear!

> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/028.out       | 2 +-
>  tests/qemu-iotests/130.out       | 4 ++--
>  tests/qemu-iotests/common.filter | 7 +++++++
>  tests/qemu-iotests/common.qemu   | 4 ++--
>  4 files changed, 12 insertions(+), 5 deletions(-)

Yay!  But I think you're incomplete:

What about 051, 068, 142, and 145?

(found by:
 git grep -l $'\e' tests/qemu-iotests/*.out
using bash as the shell)


> +++ b/tests/qemu-iotests/common.filter
> @@ -86,6 +86,13 @@ _filter_qmp()
>          -e '    QMP_VERSION'
>  }
>  
> +# readline makes HMP command strings so long that git complains
> +_filter_hmp()
> +{
> +    sed -e 's/(qemu).*\o33\[D/(qemu) /g' \

\oNN is a GNU sed-ism, as far as I can tell.  Is it portable to our
BSD/MacOS builds?

> +        -e 's/\o33\[K//g'
> +}


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature