[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PULL 07/10] block: Don't check permission
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PULL 07/10] block: Don't check permissions for copy on read |
Date: |
Fri, 7 Apr 2017 09:11:11 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 04/07/2017 08:47 AM, Kevin Wolf wrote:
> The assertion is currently failing. We can't require callers to have
> write permissions when all they are doing is a read, so comment it out.
> Add a FIXME comment in the code so that the check is re-enabled when
> copy on read is refactored into its own filter driver.
>
> Reported-by: Richard W.M. Jones <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Richard W.M. Jones <address@hidden>
> ---
> block/io.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/block/io.c b/block/io.c
> index 2709a70..7321dda 100644
> --- a/block/io.c
> +++ b/block/io.c
> @@ -945,7 +945,14 @@ static int coroutine_fn
> bdrv_co_do_copy_on_readv(BdrvChild *child,
> size_t skip_bytes;
> int ret;
>
> - assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE));
> + /* FIXME We cannot require callers to have write permissions when all
> they
> + * are doing is a read request. If we did things right, write permissions
> + * would be obtained anyway, but internally by the copy-on-read code. As
> + * long as it is implemented here rather than in a separat filter driver,
Is there time to fix the typo before the pull happens?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PULL 00/10] Block layer fixes for 2.9.0-rc4, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 01/10] block: Ignore guest dev permissions during incoming migration, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 03/10] commit: Set commit_top_bs->total_sectors, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 02/10] commit: Set commit_top_bs->aio_context, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 04/10] block/mirror: Fix use-after-free, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 05/10] iotests: Add mirror tests for orphaned source, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 06/10] qemu-img: img_create does not support image-opts, fix docs, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 09/10] block: Assert attached child node has right aio context, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 07/10] block: Don't check permissions for copy on read, Kevin Wolf, 2017/04/07
- Re: [Qemu-block] [Qemu-devel] [PULL 07/10] block: Don't check permissions for copy on read,
Eric Blake <=
- [Qemu-block] [PULL 08/10] block: Fix unpaired aio_disable_external in external snapshot, Kevin Wolf, 2017/04/07
- [Qemu-block] [PULL 10/10] mirror: Fix aio context of mirror_top_bs, Kevin Wolf, 2017/04/07
- Re: [Qemu-block] [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4, Peter Maydell, 2017/04/07
- Re: [Qemu-block] [Qemu-devel] [PULL 00/10] Block layer fixes for 2.9.0-rc4, no-reply, 2017/04/12