[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2] vl: disable default cdrom when
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2] vl: disable default cdrom when using explicitely scsi-hd |
Date: |
Tue, 28 Feb 2017 11:40:49 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 27/02/2017 20:25, John Snow wrote:
>
>
> On 02/27/2017 01:45 PM, Hervé Poussineau wrote:
>> Ping?
>>
>> Le 20/02/2017 à 21:41, Hervé Poussineau a écrit :
>>> In commit af6bf1328ef90fae617857c02697e0174b84d596 (May 2011),
>>> ide-hd, ide-cd and scsi-cd have been added to disable default cdrom,
>>> "or else you can't put one on secondary master without -nodefaults".
>>>
>>> Make it the same for scsi-hd, so you can put one on scsi-id 2 without
>>> using -nodefaults.
>>> scsi-hd has probably been forgotten, as it has been added in the
>>> preceding commit (b443ae67130d32ad06b06fc9aa6d04d05ccd93ce).
>>>
>>> Affected users are the ones using a machine with SCSI devices and
>>> start QEMU
>>> with -device scsi-hd but without -device scsi-cd or -cdrom
>>> In that case, the default cdrom device will disappear instead of being
>>> empty.
>>>
>>> Signed-off-by: Hervé Poussineau <address@hidden>
>>> ---
>>> vl.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/vl.c b/vl.c
>>> index 27d9829..4af95b3 100644
>>> --- a/vl.c
>>> +++ b/vl.c
>>> @@ -226,6 +226,7 @@ static struct {
>>> { .driver = "ide-hd", .flag = &default_cdrom },
>>> { .driver = "ide-drive", .flag = &default_cdrom },
>>> { .driver = "scsi-cd", .flag = &default_cdrom },
>>> + { .driver = "scsi-hd", .flag = &default_cdrom },
>>> { .driver = "virtio-serial-pci", .flag = &default_virtcon },
>>> { .driver = "virtio-serial", .flag = &default_virtcon },
>>> { .driver = "VGA", .flag = &default_vga },
>>>
>>
>>
>
> ACK
>
> Paolo, for you?
Or for Eduardo or Markus... I'll pick it.
Paolo