Re: [Qemu-block] [Qemu-devel] [PATCH v2 7/7] QAPI: Fix blockdev-add example documentation

[Fam Zheng]

On Wed, 01/25 12:42, Jeff Cody wrote:
> Signed-off-by: Jeff Cody <address@hidden>
> ---
>  qapi/block-core.json | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/qapi/block-core.json b/qapi/block-core.json
> index 4ebb8d8..adc089f 100644
> --- a/qapi/block-core.json
> +++ b/qapi/block-core.json
> @@ -2909,21 +2909,24 @@
>  # 1.
>  # -> { "execute": "blockdev-add",
>  #      "arguments": {
> -#          "options" : { "driver": "qcow2",
> -#                        "file": { "driver": "file",
> -#                                  "filename": "test.qcow2" } } } }
> +#           "driver": "qcow2",
> +#           "node-name": "test1",
> +#           "file": {
> +#               "driver": "file",
> +#               "filename": "test.qcow2"
> +#            }
> +#       }
> +#     }
>  # <- { "return": {} }
>  #
>  # 2.
>  # -> { "execute": "blockdev-add",
>  #      "arguments": {
> -#          "options": {
>  #            "driver": "qcow2",
>  #            "node-name": "node0",
>  #            "discard": "unmap",
>  #            "cache": {
> -#                "direct": true,
> -#                "writeback": true
> +#                "direct": true
>  #            },
>  #            "file": {
>  #                "driver": "file",
> @@ -2936,7 +2939,6 @@
>  #                    "filename": "/dev/fdset/4"
>  #                }
>  #            }
> -#          }
>  #        }
>  #      }
>  #
> @@ -2964,14 +2966,12 @@
>  #
>  # -> { "execute": "blockdev-add",
>  #      "arguments": {
> -#          "options": {
>  #              "driver": "qcow2",
>  #              "node-name": "node0",
>  #              "file": {
>  #                  "driver": "file",
>  #                  "filename": "test.qcow2"
>  #              }
> -#          }
>  #      }
>  #    }
>  # <- { "return": {} }
> -- 
> 2.9.3
> 
> 

The alignments are a bit odd now but the syntax looks correct. Is it worth to
reindent while we are at it?

Fam