[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 06/18] nbd/client: refactor drop_sync
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 06/18] nbd/client: refactor drop_sync |
Date: |
Mon, 6 Feb 2017 17:19:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/03/2017 09:47 AM, Vladimir Sementsov-Ogievskiy wrote:
> Return 0 on success to simplify success checking.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
> nbd/client.c | 35 +++++++++++++++++++----------------
> 1 file changed, 19 insertions(+), 16 deletions(-)
I'm not sure that this simplifies anything. You have a net addition in
lines of code, so unless some later patch is improved because of this,
I'm inclined to say this is needless churn.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 00/18] nbd: BLOCK_STATUS, Vladimir Sementsov-Ogievskiy, 2017/02/03
- [Qemu-block] [PATCH 02/18] nbd-server: refactor simple reply sending, Vladimir Sementsov-Ogievskiy, 2017/02/03
- [Qemu-block] [PATCH 13/18] nbd: add nbd_dirty_bitmap_load, Vladimir Sementsov-Ogievskiy, 2017/02/03
- [Qemu-block] [PATCH 10/18] block/dirty-bitmap: add bdrv_load_dirty_bitmap, Vladimir Sementsov-Ogievskiy, 2017/02/03
- [Qemu-block] [PATCH 16/18] iotests: add test for nbd dirty bitmap export, Vladimir Sementsov-Ogievskiy, 2017/02/03
- [Qemu-block] [PATCH 06/18] nbd/client: refactor drop_sync, Vladimir Sementsov-Ogievskiy, 2017/02/03
- Re: [Qemu-block] [PATCH 06/18] nbd/client: refactor drop_sync,
Eric Blake <=
- [Qemu-block] [PATCH 18/18] nbd: BLOCK_STATUS for standard get_block_status function: client part, Vladimir Sementsov-Ogievskiy, 2017/02/03
- [Qemu-block] [PATCH 01/18] nbd: rename NBD_REPLY_MAGIC to NBD_SIMPLE_REPLY_MAGIC, Vladimir Sementsov-Ogievskiy, 2017/02/03
- [Qemu-block] [PATCH 04/18] nbd/client: refactor nbd_receive_starttls, Vladimir Sementsov-Ogievskiy, 2017/02/03