Re: [Qemu-block] [Qemu-devel] [PATCH 1/2] block: Rename raw_bsd to raw.c

[Laszlo Ersek]

On 10/20/16 03:11, Eric Blake wrote:
> The file has nothing to do with the BSD operating system,

The name carries "_bsd" because of the license that covers the file.
While the file has nothing to do with the BSD operating system, it is
fully related to the BSD license. Please see commit range

  e1c66c6d82fe^..e5b1d99f5528

So, I recommend to remove the BSD/BDS language from the commit message;
it makes the current name appear as a typo. It was not a typo.

Other than that, I entirely welcome this series; I still get confused
about protocol drivers vs. format drivers. Based on an explanation I got
from Kevin two and a half years ago :), for exactly this set of source
files, "raw_bsd.c" (now "raw.c") is a format driver, while "raw-posix.c"
(now "file-posix.c") is a protocol driver. I think the proposed names
render these roles easier to understand.

Thanks!
Laszlo

> but
> is rather dealing with the raw data format as a BDS.  Simplify
> the name to avoid further confusion.  [Plus I hate typing _ in
> file names - the shift key slows things down]
> 
> Suggested-by: Daniel P. Berrange <address@hidden>
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  block/{raw_bsd.c => raw.c} | 0
>  MAINTAINERS                | 2 +-
>  block/Makefile.objs        | 2 +-
>  3 files changed, 2 insertions(+), 2 deletions(-)
>  rename block/{raw_bsd.c => raw.c} (100%)
> 
> diff --git a/block/raw_bsd.c b/block/raw.c
> similarity index 100%
> rename from block/raw_bsd.c
> rename to block/raw.c
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b01fec0..6f984c3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1677,7 +1677,7 @@ F: block/linux-aio.c
>  F: include/block/raw-aio.h
>  F: block/raw-posix.c
>  F: block/raw-win32.c
> -F: block/raw_bsd.c
> +F: block/raw.c
>  F: block/win32-aio.c
> 
>  qcow2
> diff --git a/block/Makefile.objs b/block/Makefile.objs
> index 67a036a..c10941e 100644
> --- a/block/Makefile.objs
> +++ b/block/Makefile.objs
> @@ -1,4 +1,4 @@
> -block-obj-y += raw_bsd.o qcow.o vdi.o vmdk.o cloop.o bochs.o vpc.o vvfat.o 
> dmg.o
> +block-obj-y += raw.o qcow.o vdi.o vmdk.o cloop.o bochs.o vpc.o vvfat.o dmg.o
>  block-obj-y += qcow2.o qcow2-refcount.o qcow2-cluster.o qcow2-snapshot.o 
> qcow2-cache.o
>  block-obj-y += qed.o qed-gencb.o qed-l2-cache.o qed-table.o qed-cluster.o
>  block-obj-y += qed-check.o
>