Re: [Qemu-block] [PATCH 07/22] qcow2-bitmap: introduce auto-loading bitmaps

[Vladimir Sementsov-Ogievskiy]

On 01.10.2016 19:26, Max Reitz wrote:
> On 30.09.2016 12:53, Vladimir Sementsov-Ogievskiy wrote:
> > Auto loading bitmaps are bitmaps in Qcow2, with AUTO flag set. They are

[...]

> diff --git a/block/qcow2.c b/block/qcow2.c
> index 08c4ef9..02ec224 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -213,6 +213,11 @@ static int qcow2_read_extensions(BlockDriverState *bs, 
> uint64_t start_offset,
>               s->bitmap_directory_size =
>                       bitmaps_ext.bitmap_directory_size;
>   
> +            ret = qcow2_read_bitmaps(bs, errp);
> +            if (ret < 0) {
> +                return ret;
> +            }
> +
> I think I'd put this directly into qcow2_open(), just like
> qcow2_read_snapshots(); but that's an optional suggestion.
>
> Max

Snapshots are not header extension.. so it is not the case. Here 
qcow2_read_bitmaps looks like part of header extension loading, and 
header extension fields describe other parts of the extension.. I think 
this is a good point, isn't it?

--
Best regards,
Vladimir