[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH 12/18] iothread: detach all block devices before sto
From: |
Paolo Bonzini |
Subject: |
[Qemu-block] [PATCH 12/18] iothread: detach all block devices before stopping them |
Date: |
Thu, 13 Oct 2016 19:34:16 +0200 |
Soon bdrv_drain will not call aio_poll itself on iothreads. If block
devices are left hanging off the iothread's AioContext, there will be no
one to do I/O for those poor devices.
Signed-off-by: Paolo Bonzini <address@hidden>
---
iothread.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/iothread.c b/iothread.c
index 62c8796..8153e21 100644
--- a/iothread.c
+++ b/iothread.c
@@ -16,6 +16,7 @@
#include "qom/object_interfaces.h"
#include "qemu/module.h"
#include "block/aio.h"
+#include "block/block.h"
#include "sysemu/iothread.h"
#include "qmp-commands.h"
#include "qemu/error-report.h"
@@ -199,6 +200,15 @@ IOThreadInfoList *qmp_query_iothreads(Error **errp)
void iothread_stop_all(void)
{
Object *container = object_get_objects_root();
+ BlockDriverState *bs;
+ BdrvNextIterator it;
+
+ for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
+ AioContext *ctx = bdrv_get_aio_context(bs);
+ aio_context_acquire(ctx);
+ bdrv_set_aio_context(bs, qemu_get_aio_context());
+ aio_context_release(ctx);
+ }
object_child_foreach(container, iothread_stop, NULL);
}
--
2.7.4
- [Qemu-block] [PATCH 08/18] nfs: move nfs_set_events out of the while loops, (continued)
- [Qemu-block] [PATCH 08/18] nfs: move nfs_set_events out of the while loops, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 09/18] nfs: use bdrv_poll_while and bdrv_wakeup, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 11/18] aio: introduce qemu_get_current_aio_context, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 10/18] sheepdog: use bdrv_poll_while and bdrv_wakeup, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 13/18] replication: pass BlockDriverState to reopen_backing_file, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 12/18] iothread: detach all block devices before stopping them,
Paolo Bonzini <=
- [Qemu-block] [PATCH 14/18] block: prepare bdrv_reopen_multiple to release AioContext, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 15/18] block: only call aio_poll on the current thread's AioContext, Paolo Bonzini, 2016/10/13
- [Qemu-block] [PATCH 17/18] qemu-thread: introduce QemuRecMutex, Paolo Bonzini, 2016/10/13