|
From: | Wei Xu |
Subject: | Re: [Qemu-block] [PATCH for 2.8 02/11] virtio: convert to use DMA api |
Date: | Mon, 5 Sep 2016 10:26:28 +0800 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 2016年08月30日 11:06, Jason Wang wrote:
@@ -1587,6 +1595,11 @@ static void virtio_pci_device_plugged(DeviceState *d, Error **errp) } if (legacy) { + if (virtio_host_has_feature(vdev, VIRTIO_F_IOMMU_PLATFORM)) { + error_setg(errp, "VIRTIO_F_IOMMU_PLATFORM was supported by" + "neither legacy nor transitional device."); + return ; + }
Not sure if i understand it correctly, the transitional device here maybe a bit hard to understand, just a tip for your convenience, besides the denied prompt, can we add what kind of device is supported to the message? such as modern device only, like this.
"VIRTIO_F_IOMMU_PLATFORM is supported by modern device only, it is not supported by either legacy or transitional device."
/* legacy and transitional */ pci_set_word(config + PCI_SUBSYSTEM_VENDOR_ID, pci_get_word(config + PCI_VENDOR_ID));
[Prev in Thread] | Current Thread | [Next in Thread] |