qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH for-2.8 v3 3/3] dmg: Move libbz2 code to dmg-bz2


From: Stefan Hajnoczi
Subject: Re: [Qemu-block] [PATCH for-2.8 v3 3/3] dmg: Move libbz2 code to dmg-bz2.so
Date: Wed, 17 Aug 2016 09:35:16 +0100
User-agent: Mutt/1.6.2 (2016-07-01)

On Wed, Aug 17, 2016 at 03:20:33PM +0800, Fam Zheng wrote:
> +#include "qemu/osdep.h"
> +#include "qemu-common.h"
> +#include "dmg.h"
> +#include <bzlib.h>
...
> diff --git a/block/dmg.h b/block/dmg.h
> new file mode 100644
> index 0000000..b592d6f
> --- /dev/null
> +++ b/block/dmg.h
...
> +#include "qemu/osdep.h"
> +#include "qemu-common.h"
> +#include "block/block_int.h"
> +#include <zlib.h>

If you respin please put system headers before user headers.

That way it's clear that user headers don't define anything that affects
the behavior of system headers.

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]