Re: [Qemu-block] [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
0a93007 qemu-iotests: Add test case 153 for image locking
3fe871c block: Turn on image locking by default
95e318e tests: Use null-co:// instead of /dev/null
ffd5c0a iotests: Disable image locking in 085
ff4e648 iotests: 130: Check image info locklessly
23213a9 iotests: 087: Disable image locking in cases where file is shared
a98e4f0 qemu-iotests: 030: Disable image locking when checking test image
1b052c5 qemu-iotests: Wait for QEMU processes before checking image in 091
74b6e02 qemu-iotests: 046: Move version detection out from verify_io
75b6dac block: Don't lock drive-backup target image in none mode
cc08d0b qemu-nbd: Add "--no-lock/-L" option
d996114 qemu-img: Update documentation of "-L" option
5cd0c72 qemu-img: Add "-L" option to sub commands
dc1e924 qemu-io: Add "-L" option for BDRV_O_NO_LOCK
6104ab5 raw-posix: Add image locking support
cfd1487 osdep: Add qemu_lock_fd and qemu_unlock_fd
f455bc2 block: Introduce image file locking
b2af979 block: Add and parse "lock-mode" option for image locking
483596d qapi: Add lock-mode in blockdev-add options
88916dc block: Add flag bits for image locking

=== OUTPUT BEGIN ===
Checking PATCH 1/20: block: Add flag bits for image locking...
Checking PATCH 2/20: qapi: Add lock-mode in blockdev-add options...
Checking PATCH 3/20: block: Add and parse "lock-mode" option for image 
locking...
ERROR: do not use assignment in if condition
#80: FILE: blockdev.c:548:
+    if ((buf = qemu_opt_get(opts, BDRV_OPT_LOCK_MODE)) != NULL) {

total: 1 errors, 0 warnings, 86 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 4/20: block: Introduce image file locking...
Checking PATCH 5/20: osdep: Add qemu_lock_fd and qemu_unlock_fd...
Checking PATCH 6/20: raw-posix: Add image locking support...
Checking PATCH 7/20: qemu-io: Add "-L" option for BDRV_O_NO_LOCK...
Checking PATCH 8/20: qemu-img: Add "-L" option to sub commands...
Checking PATCH 9/20: qemu-img: Update documentation of "-L" option...
Checking PATCH 10/20: qemu-nbd: Add "--no-lock/-L" option...
Checking PATCH 11/20: block: Don't lock drive-backup target image in none 
mode...
Checking PATCH 12/20: qemu-iotests: 046: Move version detection out from 
verify_io...
Checking PATCH 13/20: qemu-iotests: Wait for QEMU processes before checking 
image in 091...
Checking PATCH 14/20: qemu-iotests: 030: Disable image locking when checking 
test image...
Checking PATCH 15/20: iotests: 087: Disable image locking in cases where file 
is shared...
Checking PATCH 16/20: iotests: 130: Check image info locklessly...
ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#47: FILE: tests/qemu-iotests/130.out:13:
+(qemu) q
         ^

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#55: FILE: tests/qemu-iotests/130.out:20:
+(qemu) q
         ^

total: 2 errors, 0 warnings, 32 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 17/20: iotests: Disable image locking in 085...
Checking PATCH 18/20: tests: Use null-co:// instead of /dev/null...
Checking PATCH 19/20: block: Turn on image locking by default...
Checking PATCH 20/20: qemu-iotests: Add test case 153 for image locking...
=== OUTPUT END ===

Test command exited with code: 1