[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 02/11] block: Accept node-name for block-comm
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v5 02/11] block: Accept node-name for block-commit |
Date: |
Wed, 3 Aug 2016 14:54:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 03.08.2016 13:21, Kevin Wolf wrote:
> In order to remove the necessity to use BlockBackend names in the
> external API, we want to allow node-names everywhere. This converts
> block-commit to accept a node-name without lifting the restriction that
> we're operating at a root node.
>
> As libvirt makes use of the DeviceNotFound error class, we must add
> explicit code to retain this behaviour because qmp_get_root_bs() only
> returns GenericErrors.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> blockdev.c | 23 +++++++++++------------
> qapi/block-core.json | 2 +-
> qmp-commands.hx | 2 +-
> 3 files changed, 13 insertions(+), 14 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 00/11] block: Accept node-name in all node level QMP commands, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 02/11] block: Accept node-name for block-commit, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 04/11] block: Accept node-name for blockdev-mirror, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 01/11] block: Accept node-name for block-stream, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 03/11] block: Accept node-name for blockdev-backup, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 06/11] block: Accept node-name for blockdev-snapshot-internal-sync, Kevin Wolf, 2016/08/03
- [Qemu-block] [PATCH v5 05/11] block: Accept node-name for blockdev-snapshot-delete-internal-sync, Kevin Wolf, 2016/08/03