|
| From: | Alberto Garcia |
| Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH for-2.7 1/2] throttle: Don't allow burst limits to be lower than the normal limits |
| Date: | Thu, 28 Jul 2016 00:45:20 +0200 |
| User-agent: | Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Thu 28 Jul 2016 12:33:51 AM CEST, Eric Blake <address@hidden> wrote:
>> + if (cfg->buckets[i].max && cfg->buckets[i].max <
>> cfg->buckets[i].avg) {
>> + error_setg(errp, "if bps_max/iops_max is set it cannot be lower"
>> + " than the bps/iops values");
>
> Feels a bit long, I'd be fine with "bps_max/iops_max must not be lower
> than bps/iops values". But the idea makes sense.
That's not strictly true since the default value of bps_max is 0 (unless
we forbid setting it explicitly to 0 as well).
Berto
| [Prev in Thread] | Current Thread | [Next in Thread] |