Re: [Qemu-block] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint

[Max Reitz]

On 22.07.2016 12:15, Wang WeiWei wrote:
> From: Wen Congyang <address@hidden>
> 
> Signed-off-by: Wen Congyang <address@hidden>
> Signed-off-by: zhanghailiang <address@hidden>
> Signed-off-by: Gonglei <address@hidden>
> Signed-off-by: Changlong Xie <address@hidden>
> Signed-off-by: Wang WeiWei <address@hidden>
> ---
>  block/backup.c               | 18 ++++++++++++++++++
>  include/block/block_backup.h |  3 +++
>  2 files changed, 21 insertions(+)
>  create mode 100644 include/block/block_backup.h

[...]

> diff --git a/include/block/block_backup.h b/include/block/block_backup.h
> new file mode 100644
> index 0000000..3753bcb
> --- /dev/null
> +++ b/include/block/block_backup.h
> @@ -0,0 +1,3 @@
> +#include "block/block_int.h"
> +
> +void backup_do_checkpoint(BlockJob *job, Error **errp);

Include guards and copyright notice missing. I don't mind the missing
copyright notice because it will default to GPL anyway. Also, I
personally don't really mind the missing include guards, but I thought
I'd say something anyway.

Max

signature.asc
Description: OpenPGP digital signature