Re: [Qemu-block] [PATCH v4 17/32] blockdev: Separate bochs probe from its driver

[Max Reitz]

On 14.07.2016 21:03, Colin Lord wrote:
> Modifies the bochs probe to return the format name as well as the
> score as the final step of separating the probe function from the
> driver. This keeps the probe completely independent of the driver,
> making future modularization easier to accomplish. Returning the format
> name as well as the score allows the score to be correlated to the
> driver without the probe function needing to be part of the driver.
> 
> Signed-off-by: Colin Lord <address@hidden>
> ---
>  block.c               | 20 ++++++++++++++++++++
>  block/bochs-probe.c   | 25 ++++++++++++++++---------
>  block/bochs.c         |  1 -
>  include/block/probe.h |  3 ++-
>  4 files changed, 38 insertions(+), 11 deletions(-)
> 
> diff --git a/block.c b/block.c
> index 3a0dc19..b16f8cf 100644
> --- a/block.c
> +++ b/block.c
> @@ -25,6 +25,7 @@
>  #include "trace.h"
>  #include "block/block_int.h"
>  #include "block/blockjob.h"
> +#include "block/probe.h"
>  #include "qemu/error-report.h"
>  #include "module_block.h"
>  #include "qemu/module.h"
> @@ -56,6 +57,13 @@
>  
>  #define NOT_DONE 0x7fffffff /* used while emulated sync operation in 
> progress */
>  
> +typedef const char *BdrvProbeFunc(const uint8_t *buf, int buf_size,
> +                                  const char *filename, int *score);
> +
> +static BdrvProbeFunc *format_probes[] = {
> +    bdrv_bochs_probe,
> +};
> +

I really can't convince you of my "struct concept", can I? :-)

Unless maybe I can:

Reviewed-by: Max Reitz <address@hidden>

signature.asc
Description: OpenPGP digital signature