[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 10/11] nbd-server: Use a separate BlockBacken
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH v4 10/11] nbd-server: Use a separate BlockBackend |
Date: |
Thu, 14 Jul 2016 15:30:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 07/14/2016 07:28 AM, Kevin Wolf wrote:
> The builtin NBD server uses its own BlockBackend now instead of reusing
> the monitor/guest device one.
>
> This means that it has its own writethrough setting now. The builtin
> NBD server always uses writeback caching now regardless of whether the
> guest device has WCE enabled. qemu-nbd respects the cache mode given on
> the command line.
>
> We still need to keep a reference to the monitor BB because we put an
> eject notifier on it, but we don't use it for any I/O.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block.c | 2 ++
> blockdev-nbd.c | 4 ++--
> include/block/nbd.h | 3 ++-
> nbd/server.c | 25 ++++++++++++++++++++-----
> qemu-nbd.c | 4 ++--
> 5 files changed, 28 insertions(+), 10 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v4 07/11] block: Accept node-name for change-backing-file, (continued)
- [Qemu-block] [PATCH v4 06/11] block: Accept node-name for blockdev-snapshot-internal-sync, Kevin Wolf, 2016/07/14
- [Qemu-block] [PATCH v4 08/11] block: Accept node-name for drive-backup, Kevin Wolf, 2016/07/14
- [Qemu-block] [PATCH v4 09/11] block: Accept node-name for drive-mirror, Kevin Wolf, 2016/07/14
- [Qemu-block] [PATCH v4 10/11] nbd-server: Use a separate BlockBackend, Kevin Wolf, 2016/07/14
- Re: [Qemu-block] [PATCH v4 10/11] nbd-server: Use a separate BlockBackend,
Eric Blake <=
- [Qemu-block] [PATCH v4 11/11] nbd-server: Allow node name for nbd-server-add, Kevin Wolf, 2016/07/14