[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v5 02/15] block/io: reuse bdrv_co_p
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v5 02/15] block/io: reuse bdrv_co_pwritev() for write compressed |
Date: |
Thu, 14 Jul 2016 13:17:05 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Mon, Jul 04, 2016 at 03:28:13PM +0300, Denis V. Lunev wrote:
> From: Pavel Butsykin <address@hidden>
>
> For bdrv_pwrite_compressed() it looks like most of the code creating
> coroutine is duplicated in bdrv_prwv_co(). So we can just add a flag
> (BDRV_REQ_WRITE_COMPRESSED) and use bdrv_prwv_co() as a generic one.
> In the end we get coroutine oriented function for write compressed by using
> bdrv_co_pwritev/blk_co_pwritev with BDRV_REQ_WRITE_COMPRESSED flag.
>
> Signed-off-by: Pavel Butsykin <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Jeff Cody <address@hidden>
> CC: Markus Armbruster <address@hidden>
> CC: Eric Blake <address@hidden>
> CC: John Snow <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Kevin Wolf <address@hidden>
> ---
> block/io.c | 57
> ++++++++++++++++++++++++++++++++++-------------
> include/block/block.h | 3 ++-
> include/block/block_int.h | 3 +++
> qemu-img.c | 2 +-
> 4 files changed, 47 insertions(+), 18 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v5 00/15] backup compression, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 04/15] qcow2: cleanup qcow2_co_pwritev_compressed to avoid the recursion, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 02/15] block/io: reuse bdrv_co_pwritev() for write compressed, Denis V. Lunev, 2016/07/04
- Re: [Qemu-block] [Qemu-devel] [PATCH v5 02/15] block/io: reuse bdrv_co_pwritev() for write compressed,
Stefan Hajnoczi <=
- [Qemu-block] [PATCH v5 03/15] qcow2: add qcow2_co_pwritev_compressed, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 05/15] vmdk: add vmdk_co_pwritev_compressed, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 01/15] block: switch blk_write_compressed() to byte-based interface, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 06/15] qcow: add qcow_co_pwritev_compressed, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 07/15] qcow: cleanup qcow_co_pwritev_compressed to avoid the recursion, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 09/15] block/io: turn on dirty_bitmaps for the compressed writes, Denis V. Lunev, 2016/07/04
- [Qemu-block] [PATCH v5 08/15] block: remove BlockDriver.bdrv_write_compressed, Denis V. Lunev, 2016/07/04