[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 00/11] Allow creating block jobs with a user-
From: |
John Snow |
Subject: |
Re: [Qemu-block] [PATCH v4 00/11] Allow creating block jobs with a user-defined ID |
Date: |
Thu, 7 Jul 2016 11:34:13 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 07/07/2016 11:12 AM, Alberto Garcia wrote:
> On Thu 07 Jul 2016 02:48:17 PM CEST, Kevin Wolf wrote:
>>> Hi all,
>>>
>>> block jobs are currently identified by the name of the block backend
>>> of the BDS where the job was started.
>>>
>>> The problem with this is that you cannot have block jobs on nodes
>>> where there is no such name.
>>>
>>> This series turns the 'id' field of the BlockJob structure into an
>>> actual ID, it guarantees that is unique and always present and allows
>>> the user to set it.
>>
>> Thanks, applied to the block branch.
>
> Thanks Kevin,
>
> I would still like to have an ACK from John Snow, not necessarily a
> complete review of the series but I definitely want to avoid any
> fundamental conflict with the "Jobs 2.0 API" that is in the works.
>
> Berto
>
It's fine, I'm lagging behind with my upstream stuff. You're doing the
work and I'm not right now, so I lose my chance to complain :)
I appreciate the kindness, though.
ACK.
- Re: [Qemu-block] [PATCH v4 10/11] qemu-img: Set the ID of the block job in img_commit(), (continued)
- [Qemu-block] [PATCH v4 03/11] blockjob: Add block_job_get(), Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 01/11] stream: Fix prototype of stream_start(), Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 06/11] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror', Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 02/11] blockjob: Update description of the 'id' field, Alberto Garcia, 2016/07/05
- [Qemu-block] [PATCH v4 09/11] commit: Add 'job-id' parameter to 'block-commit', Alberto Garcia, 2016/07/05
- Re: [Qemu-block] [PATCH v4 00/11] Allow creating block jobs with a user-defined ID, Kevin Wolf, 2016/07/07