Re: [Qemu-block] [PATCH v3 17/32] blockdev: Separate bochs probe from its driver

[Max Reitz]

On 05.07.2016 17:24, Colin Lord wrote:
> Modifies the bochs probe to return the format name as well as the
> score as the final step of separating the probe function from the
> driver. This keeps the probe completely independent of the driver,
> making future modularization easier to accomplish. Returning the format
> name as well as the score allows the score to be correlated to the
> driver without the probe function needing to be part of the driver.
> 
> Signed-off-by: Colin Lord <address@hidden>
> ---
>  block.c               | 19 +++++++++++++++++++
>  block/bochs.c         |  1 -
>  block/probe/bochs.c   | 25 ++++++++++++++++---------
>  include/block/probe.h |  3 ++-
>  4 files changed, 37 insertions(+), 11 deletions(-)

Oh, and another comment: I think it would be better to split this patch
into a part that modifies block.c (introducing the format_probes array
and using it in bdrv_probe_all()) and another one that actually does the
bochs-specific stuff.

Max

signature.asc
Description: OpenPGP digital signature