[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 0/4] block: ignore flush requests when storag
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-block] [PATCH v5 0/4] block: ignore flush requests when storage is clean |
Date: |
Mon, 4 Jul 2016 16:53:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 04/07/2016 16:38, Denis V. Lunev wrote:
> Changes from v4:
> - Moved to write generation scheme instead of dirty flag
> - Added retry setup to IDE PIO and FLUSH requests
>
> Changes from v3:
> - Fixed a typo in commit message
> - Rebased on Kevin'n origin/block
>
> Changes from v2:
> - Better comments
> - Rebased on latest master
>
> Changes from v1:
> - Flush requests that should be skipped will now wait for completion
> of any previous requests already in flight
> - Fixed IDE and AHCI tests to dirty media for new flush behaviour
> - Fixed a problem in IDE CMD_FLUSH_CACHE failure handling
>
> Signed-off-by: Evgeny Yakovlev <address@hidden>
> Signed-off-by: Denis V. Lunev <address@hidden>
> CC: Kevin Wolf <address@hidden>
> CC: Max Reitz <address@hidden>
> CC: Stefan Hajnoczi <address@hidden>
> CC: Fam Zheng <address@hidden>
> CC: John Snow <address@hidden>
>
> Evgeny Yakovlev (4):
> ide: refactor retry_unit set and clear into separate function
> ide: set retry_unit for PIO and FLUSH requests
> tests: in IDE and AHCI tests perform DMA write before flushing
> block: ignore flush requests when storage is clean
>
> block.c | 3 +++
> block/io.c | 18 ++++++++++++++++++
> hw/ide/core.c | 24 ++++++++++++++++++------
> include/block/block_int.h | 5 +++++
> tests/ahci-test.c | 34 ++++++++++++++++++++++++++++++++--
> tests/ide-test.c | 43 +++++++++++++++++++++++++++++++++++++++++++
> 6 files changed, 119 insertions(+), 8 deletions(-)
>
Reviewed-by: Paolo Bonzini <address@hidden>
Thanks!
Paolo