[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 16/22] block: Wording tweaks to write zeroes
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH v3 16/22] block: Wording tweaks to write zeroes limits |
Date: |
Fri, 24 Jun 2016 14:12:31 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Thu, 06/23 16:37, Eric Blake wrote:
> Improve the documentation of the write zeroes limits, to mention
> additional constraints that drivers should observe. Worth squashing
> into commit cf081fca, if that hadn't been pushed already :)
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v3: new patch, split off from "block: Switch discard length bounds..."
> ---
> include/block/block_int.h | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/include/block/block_int.h b/include/block/block_int.h
> index 7d2b152..7a4a00f 100644
> --- a/include/block/block_int.h
> +++ b/include/block/block_int.h
> @@ -331,11 +331,14 @@ typedef struct BlockLimits {
> int64_t discard_alignment;
>
> /* maximum number of bytes that can zeroized at once (since it is
> - * signed, it must be < 2G, if set) */
> + * signed, it must be < 2G, if set), should be multiple of
> + * pwrite_zeroes_alignment. May be 0 if no inherent 32-bit limit */
"inherent 32-bit limit"? What is special about 32-bit other than this field is
32-bit? Anyway,
Reviewed-by: Fam Zheng <address@hidden>
> int32_t max_pwrite_zeroes;
>
> /* optimal alignment for write zeroes requests in bytes, must be
> - * power of 2, and less than max_pwrite_zeroes if that is set */
> + * power of 2, less than max_pwrite_zeroes if that is set, and
> + * multiple of bs->request_alignment. May be 0 if
> + * bs->request_alignment is good enough */
> uint32_t pwrite_zeroes_alignment;
>
> /* optimal transfer length in bytes (must be power of 2, and
> --
> 2.5.5
>
- [Qemu-block] [PATCH v3 03/22] block: Fix harmless off-by-one in bdrv_aligned_preadv(), (continued)
- [Qemu-block] [PATCH v3 03/22] block: Fix harmless off-by-one in bdrv_aligned_preadv(), Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 14/22] block: Set default request_alignment during bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 07/22] scsi: Advertise limits by blocksize, not 512, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 11/22] qcow2: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 12/22] raw-win32: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 21/22] block: Fix error message style, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 13/22] block: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 16/22] block: Wording tweaks to write zeroes limits, Eric Blake, 2016/06/23
- Re: [Qemu-block] [PATCH v3 16/22] block: Wording tweaks to write zeroes limits,
Fam Zheng <=
- [Qemu-block] [PATCH v3 15/22] block: Switch transfer length bounds to byte-based, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 20/22] block: Move request_alignment into BlockLimit, Eric Blake, 2016/06/23
- [Qemu-block] [PATCH v3 17/22] block: Switch discard length bounds to byte-based, Eric Blake, 2016/06/23