[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v5 01/10] block: Hide HBitmap in block dirty bit
|
From: |
Max Reitz |
|
Subject: |
Re: [Qemu-block] [PATCH v5 01/10] block: Hide HBitmap in block dirty bitmap interface |
|
Date: |
Wed, 22 Jun 2016 17:10:52 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 |
On 03.06.2016 06:32, Fam Zheng wrote:
> HBitmap is an implementation detail of block dirty bitmap that should be
> hidden
> from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying
> HBitmapIter.
>
> A small difference in the interface is, before, an HBitmapIter is initialized
> in place, now the new BdrvDirtyBitmapIter must be dynamically allocated
> because
> the structure definition is in block/dirty-bitmap.c.
>
> Two current users are converted too.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block/backup.c | 14 ++++++++------
> block/dirty-bitmap.c | 39 +++++++++++++++++++++++++++++++++------
> block/mirror.c | 24 +++++++++++++-----------
> include/block/dirty-bitmap.h | 7 +++++--
> include/qemu/typedefs.h | 1 +
> 5 files changed, 60 insertions(+), 25 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v5 00/10] Dirty bitmap changes for migration/persistence work, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 03/10] tests: Add test code for meta bitmap, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 01/10] block: Hide HBitmap in block dirty bitmap interface, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 06/10] block: Assert that bdrv_release_dirty_bitmap succeeded, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 04/10] block: Support meta dirty bitmap, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 02/10] HBitmap: Introduce "meta" bitmap to track bit changes, Fam Zheng, 2016/06/03
- [Qemu-block] [PATCH v5 05/10] block: Add two dirty bitmap getters, Fam Zheng, 2016/06/03