[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 01/15] stream: Fix prototype of stream_start(
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH v2 01/15] stream: Fix prototype of stream_start() |
|
Date: |
Wed, 22 Jun 2016 14:45:14 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 22.06.2016 um 14:24 hat Alberto Garcia geschrieben:
> 'stream-start' has a parameter called 'backing-file', which is the
> string to be written to bs->backing when the job finishes.
>
> In the stream_start() implementation it is called 'backing_file_str',
> but it the prototype in the header file it is called 'base_id'.
>
> This patch fixes it so the name is the same in both cases and is
> consistent with other cases (like commit_start()).
>
> Signed-off-by: Alberto Garcia <address@hidden>
> Reviewed-by: Max Reitz <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-block] [PATCH v2 00/15] Add an 'id' field to block jobs, Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 01/15] stream: Fix prototype of stream_start(), Alberto Garcia, 2016/06/22
- Re: [Qemu-block] [PATCH v2 01/15] stream: Fix prototype of stream_start(),
Kevin Wolf <=
- [Qemu-block] [PATCH v2 03/15] blockjob: Add block_job_get(), Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 07/15] backup: Add 'job-id' parameter to 'blockdev-backup' and 'drive-backup', Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 06/15] mirror: Add 'job-id' parameter to 'blockdev-mirror' and 'drive-mirror', Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 08/15] stream: Add 'job-id' parameter to 'block-stream', Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 05/15] blockjob: Add 'job_id' parameter to block_job_create(), Alberto Garcia, 2016/06/22
- [Qemu-block] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct, Alberto Garcia, 2016/06/22