[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 04/17] nbd: Allow larger requests
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-block] [PATCH v2 04/17] nbd: Allow larger requests |
Date: |
Mon, 20 Jun 2016 13:13:40 +0100 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Tue, Jun 14, 2016 at 03:30:26PM -0600, Eric Blake wrote:
> The NBD layer was breaking up request at a limit of 2040 sectors
> (just under 1M) to cater to old qemu-nbd. But the server limit
> was raised to 32M in commit 2d8214885 to match the kernel, more
> than three years ago; and the upstream NBD Protocol is proposing
> documentation that without any explicit communication to state
> otherwise, a client should be able to safely assume that a 32M
> transaction will work. It is time to rely on the larger sizing,
> and any downstream distro that cares about maximum
> interoperability to older qemu-nbd servers can just tweak the
> value of #define NBD_MAX_SECTORS.
>
> Signed-off-by: Eric Blake <address@hidden>
>
> ---
> v2: new patch
> ---
> include/block/nbd.h | 1 +
> block/nbd-client.c | 4 ----
> 2 files changed, 1 insertion(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-block] [PATCH v2 00/17] Byte-based block limits, Eric Blake, 2016/06/14
- [Qemu-block] [PATCH v2 02/17] block: Document supported flags during bdrv_aligned_preadv(), Eric Blake, 2016/06/14
- [Qemu-block] [PATCH v2 01/17] block: Tighter assertions on bdrv_aligned_pwritev(), Eric Blake, 2016/06/14
- [Qemu-block] [PATCH v2 04/17] nbd: Allow larger requests, Eric Blake, 2016/06/14
- [Qemu-block] [PATCH v2 03/17] block: Fix harmless off-by-one in bdrv_aligned_preadv(), Eric Blake, 2016/06/14
- [Qemu-block] [PATCH v2 05/17] nbd: Advertise realistic limits to block layer, Eric Blake, 2016/06/14
- [Qemu-block] [PATCH v2 11/17] raw-win32: Set request_alignment during .bdrv_refresh_limits(), Eric Blake, 2016/06/14