[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 02/11] nbd: More debug typo fixes, use correc
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v4 02/11] nbd: More debug typo fixes, use correct formats |
|
Date: |
Mon, 13 Jun 2016 06:21:37 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 06/13/2016 06:04 AM, Paolo Bonzini wrote:
>
>
> On 12/05/2016 00:39, Eric Blake wrote:
>> Clean up some debug message oddities missed earlier; this includes
>> some typos, and recognizing that %d is not necessarily compatible
>> with uint32_t.
>
> Actually it should be on any POSIX platform, since (by way of the
> requirements on limits.h) POSIX requires sizeof(int) to be >= 4.
Not quite true. On 32-bit platforms, uint32_t can be 'long' rather than
'int' (I think 32-bit cygwin used to be in this camp, once - I don't
remember if it is still the case). Thus, PRId32 is NOT necessarily "d"
on all platforms.
>
> I will apply the patch, but fully expect this to bitrot...
>
> Paolo
>
>> Also add a couple messages that I found useful
>> while debugging things.
>>
>> Signed-off-by: Eric Blake <address@hidden>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature