Re: [Qemu-block] [PATCH v5 19/27] qemu-iotests: 140: Disable image lock for qemu-io access

[Fam Zheng]

On Wed, 05/25 15:16, Max Reitz wrote:
> On 17.05.2016 09:35, Fam Zheng wrote:
> > The VM is still on, the image locking check would complain.
> 
> No, it wouldn't. We are opening an NBD URL that is provided by the VM.
> 
> Even if it would, we are only reading data, so an -r would probably be
> better than an -L.

You are right, I am dropping this patch.

Fam

> 
> Max
> 
> > 
> > Signed-off-by: Fam Zheng <address@hidden>
> > ---
> >  tests/qemu-iotests/140 | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/tests/qemu-iotests/140 b/tests/qemu-iotests/140
> > index 49f9df4..3be656a 100755
> > --- a/tests/qemu-iotests/140
> > +++ b/tests/qemu-iotests/140
> > @@ -70,7 +70,7 @@ _send_qemu_cmd $QEMU_HANDLE \
> >         'arguments': { 'device': 'drv' }}" \
> >      'return'
> >  
> > -$QEMU_IO_PROG -f raw -c 'read -P 42 0 64k' \
> > +$QEMU_IO_PROG -f raw -L -c 'read -P 42 0 64k' \
> >      "nbd+unix:///drv?socket=$TEST_DIR/nbd" 2>&1 \
> >      | _filter_qemu_io | _filter_nbd
> >  
> > 
> 
>