[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v4 08/15] tests: Add test code for meta bitmap
From: |
Fam Zheng |
Subject: |
Re: [Qemu-block] [PATCH v4 08/15] tests: Add test code for meta bitmap |
Date: |
Fri, 3 Jun 2016 10:38:29 +0800 |
User-agent: |
Mutt/1.6.1 (2016-04-27) |
On Fri, 03/11 15:58, Max Reitz wrote:
> > + /* Test "unset" -> "set" will update meta */
> > + hbitmap_set(data->hb, start, count);
> > + hbitmap_check_meta(data, check_start, check_count);
> > +
> > + /* Test "set" -> "set" will not update meta */
> > + hbitmap_reset_all(data->meta);
> > + hbitmap_set(data->hb, start, count);
> > + hbitmap_check_meta(data, 0, 0);
>
> Well, but if you'd do an hbitmap_set(data->hb, start, count + 1), then
> it would update meta, right?
Yes.
>
> I forgot to mention in my reply to patch 7 that the check whether
> anything in the range passed to hbitmap_set() has been changed in order
> to determine whether all of that range should be set in the meta bitmap
> seemed a bit excessive. I don't think this will hurt anyone, but still.
It is. It has been on my list to optimize the unnecessary meta update away but
I haven't done that yet.
Fam
>
> (So this is not a NACK, just a question.)
>
> Max
>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-block] [PATCH v4 08/15] tests: Add test code for meta bitmap,
Fam Zheng <=