qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwri


From: Paolo Bonzini
Subject: Re: [Qemu-block] [Qemu-devel] [PATCH V2] block/io: optimize bdrv_co_pwritev for small requests
Date: Thu, 26 May 2016 11:20:30 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0


On 26/05/2016 10:30, Fam Zheng wrote:
>> > 
>> > This doesn't look too wrong...  Should the right sequence of events be
>> > head/after_head or head/after_tail?  It's probably simplest to just emit
>> > all four events.
> I've no idea. (That's why I leaned towards fixing the test case).

Well, fixing the testcase means knowing what events should be emitted.

QEMU with Peter's patch emits head/after_head.  If the right one is
head/after_tail, _both QEMU and the testcase_ need to be adjusted.  Your
patch keeps the backwards-compatible route.

Thanks,

Paolo



reply via email to

[Prev in Thread] Current Thread [Next in Thread]