[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/9] block: Drop useless bdrv_ne
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/9] block: Drop useless bdrv_new() call |
Date: |
Tue, 17 May 2016 09:23:23 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 05/17/2016 08:41 AM, Max Reitz wrote:
> bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS
> before invoking bdrv_open() on that BDS. This is probably a relict from
s/relict/relic/
> when it used to do some modifications on that empty BDS, but now that is
> unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open()
> do the rest.
>
> Signed-off-by: Max Reitz <address@hidden>
> Reviewed-by: Alberto Garcia <address@hidden>
> Reviewed-by: Kevin Wolf <address@hidden>
> ---
> block.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v4 0/9] blockdev: (Nearly) free clean-up work, Max Reitz, 2016/05/17
- [Qemu-block] [PATCH v4 4/9] block: Drop blk_new_with_bs(), Max Reitz, 2016/05/17
- [Qemu-block] [PATCH v4 1/9] block: Drop useless bdrv_new() call, Max Reitz, 2016/05/17
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 1/9] block: Drop useless bdrv_new() call,
Eric Blake <=
- [Qemu-block] [PATCH v4 2/9] block: Let bdrv_open_inherit() return the snapshot, Max Reitz, 2016/05/17
- [Qemu-block] [PATCH v4 3/9] tests: Drop BDS from test-throttle.c, Max Reitz, 2016/05/17
- [Qemu-block] [PATCH v4 9/9] block: Drop errp parameter from blk_new(), Max Reitz, 2016/05/17
- [Qemu-block] [PATCH v4 6/9] block: Make bdrv_open() return a BDS, Max Reitz, 2016/05/17
- [Qemu-block] [PATCH v4 5/9] block: Drop bdrv_new_root(), Max Reitz, 2016/05/17
- [Qemu-block] [PATCH v4 7/9] block: Assert !bs->refcnt in bdrv_close(), Max Reitz, 2016/05/17
- [Qemu-block] [PATCH v4 8/9] block: Drop bdrv_parent_cb_...() from bdrv_close(), Max Reitz, 2016/05/17
- Re: [Qemu-block] [PATCH v4 0/9] blockdev: (Nearly) free clean-up work, Kevin Wolf, 2016/05/23