[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v2 3/9] blockjob: Don't set iostatus of target
From: |
Max Reitz |
Subject: |
Re: [Qemu-block] [PATCH v2 3/9] blockjob: Don't set iostatus of target |
Date: |
Fri, 6 May 2016 14:01:33 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.0 |
On 27.04.2016 15:20, Kevin Wolf wrote:
> When block job errors were introduced, we assigned the iostatus of the
> target BDS "just in case". The field has never been accessible for the
> user because the target isn't listed in query-block.
>
> Before we can allow the user to have a second BlockBackend on the
> target, we need to clean this up. If anything, we would want to set the
> iostatus for the internal BB of the job (which we can always do later),
> but certainly not for a separate BB which the job doesn't even use.
>
> As a nice side effect, this gets us rid of another bs->blk use.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/backup.c | 8 ++++----
> block/mirror.c | 8 ++++----
> block/stream.c | 3 +--
> blockjob.c | 6 +-----
> include/block/blockjob.h | 4 +---
> 5 files changed, 11 insertions(+), 18 deletions(-)
Reviewed-by: Max Reitz <address@hidden>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v2 3/9] blockjob: Don't set iostatus of target,
Max Reitz <=