[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3 for-2.6 3/5] virtio: Mark host notifiers as e
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-block] [PATCH v3 for-2.6 3/5] virtio: Mark host notifiers as external |
Date: |
Sun, 1 May 2016 12:55:57 +0300 |
On Sun, May 01, 2016 at 11:15:10AM +0300, Michael S. Tsirkin wrote:
> On Fri, Apr 22, 2016 at 09:53:54PM +0800, Fam Zheng wrote:
> > The effect of this change is the block layer drained section can work,
> > for example when mirror job is being completed.
> >
> > Signed-off-by: Fam Zheng <address@hidden>
>
> This is indentical to v2, so why don't you include the
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> tag I sent on v2?
Oh, I asked this before. Sorry about the noise.
> > ---
> > hw/virtio/virtio.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c
> > index fffa09f..30ede3d 100644
> > --- a/hw/virtio/virtio.c
> > +++ b/hw/virtio/virtio.c
> > @@ -1829,10 +1829,10 @@ void
> > virtio_queue_set_host_notifier_fd_handler(VirtQueue *vq, bool assign,
> > bool set_handler)
> > {
> > if (assign && set_handler) {
> > - event_notifier_set_handler(&vq->host_notifier, false,
> > + event_notifier_set_handler(&vq->host_notifier, true,
> > virtio_queue_host_notifier_read);
> > } else {
> > - event_notifier_set_handler(&vq->host_notifier, false, NULL);
> > + event_notifier_set_handler(&vq->host_notifier, true, NULL);
> > }
> > if (!assign) {
> > /* Test and clear notifier before after disabling event,
> > --
> > 2.8.0
- Re: [Qemu-block] [PATCH v3 for-2.6 3/5] virtio: Mark host notifiers as external,
Michael S. Tsirkin <=