[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v3] block: always compile-check debug prints
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [PATCH v3] block: always compile-check debug prints |
|
Date: |
Thu, 28 Apr 2016 22:15:02 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 04/28/2016 09:00 PM, Zhou Jie wrote:
> Files with conditional debug statements should ensure that the printf is
> always compiled.
> This prevents bitrot of the format string of the debug statement.
Still missing a sentence about the intentional change to use stderr.
>
> Signed-off-by: Zhou Jie <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> ---
> v1 -> v2:
> * Keep the user-visible witness as defined/undefined,
> and create a secondary witness as the actual conditional.
> * Switch debug output to stderr.
You have it here, but anything after the --- separator gets stripped by
'git am', while we want the change to stderr to be documented as part of
the permanent commit log.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature