[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 07/17] cloop: Implement .bdrv_co
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 07/17] cloop: Implement .bdrv_co_preadv() interface |
Date: |
Thu, 28 Apr 2016 20:28:19 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 04/28/2016 07:16 AM, Kevin Wolf wrote:
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/cloop.c | 38 ++++++++++++++++++++++----------------
> 1 file changed, 22 insertions(+), 16 deletions(-)
>
> for (i = 0; i < nb_sectors; i++) {
> + void *data;
> uint32_t sector_offset_in_block =
> ((sector_num + i) % s->sectors_per_block),
> block_num = (sector_num + i) / s->sectors_per_block;
> if (cloop_read_block(bs, block_num) != 0) {
> - return -1;
> + ret = -EIO;
> + goto fail;
Might want to mention in the commit message that the fix of the return
value to use negative errno is intentional.
Otherwise,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-block] [PATCH v2 03/17] block: Support AIO drivers in bdrv_driver_preadv/pwritev(), (continued)
- [Qemu-block] [PATCH v2 05/17] block: Introduce .bdrv_co_preadv/pwritev BlockDriver function, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 04/17] block: Rename bdrv_co_do_preadv/writev to bdrv_co_preadv/writev, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 06/17] bochs: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 08/17] dmg: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 07/17] cloop: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/28
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 07/17] cloop: Implement .bdrv_co_preadv() interface,
Eric Blake <=
- [Qemu-block] [PATCH v2 09/17] vdi: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 10/17] vdi: Implement .bdrv_co_pwritev() interface, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 11/17] vmdk: Add vmdk_find_offset_in_cluster(), Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 15/17] vpc: Implement .bdrv_co_pwritev() interface, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 17/17] block: Remove BlockDriver.bdrv_read/write, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 12/17] vmdk: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 14/17] vpc: Implement .bdrv_co_preadv() interface, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 16/17] vvfat: Implement .bdrv_co_preadv/pwritev interfaces, Kevin Wolf, 2016/04/28
- [Qemu-block] [PATCH v2 13/17] vmdk: Implement .bdrv_co_pwritev() interface, Kevin Wolf, 2016/04/28