[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest sock
|
From: |
Sascha Silbe |
|
Subject: |
Re: [Qemu-block] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest socket on error |
|
Date: |
Thu, 07 Apr 2016 21:58:41 +0200 |
|
User-agent: |
Notmuch/0.19+1~g6b3e223 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) |
Dear Max,
Max Reitz <address@hidden> writes:
> On 05.04.2016 11:21, Sascha Silbe wrote:
[...]
[_remove_if_exists()]
> Not sure about the leading underscore (it appears to be the only such
> function in iotests.py besides __init__()), but I guess it's a test so
> it doesn't really matter anyway.
I considered it an internal implementation detail of VM.launch(), hence
the underscore. Thinking about it some more, it may be a useful helper
for the tests themselves. But we can easily promote it whenever one of
the tests actually wants to make use of it.
Sascha
--
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641
- [Qemu-block] [PATCH 0/7] next round of qemu-iotests fixes, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 5/7] qemu-iotests: 068: don't require KVM, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 7/7] qemu-iotests: iotests.py: get rid of __all__, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 2/7] qemu-iotests: fix 051 on non-PC architectures, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 3/7] qemu-iotests: iotests.VM: remove qtest socket on error, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 1/7] qemu-iotests: check: don't place files with predictable names in /tmp, Sascha Silbe, 2016/04/05
- [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO, Sascha Silbe, 2016/04/05
- Re: [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO, Max Reitz, 2016/04/06
- Re: [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO, Kevin Wolf, 2016/04/06
- Re: [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO, Sascha Silbe, 2016/04/07
- Re: [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO, Kevin Wolf, 2016/04/08
- Re: [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO, Sascha Silbe, 2016/04/08
- Re: [Qemu-block] [PATCH 6/7] qemu-iotests: 141: reduce likelihood of race condition on systems with fast IO, Kevin Wolf, 2016/04/08