qemu-block
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-block] [PATCH 3/7] block: move restarting of throttled reqs to


From: Alberto Garcia
Subject: Re: [Qemu-block] [PATCH 3/7] block: move restarting of throttled reqs to block/throttle-groups.c
Date: Tue, 29 Mar 2016 16:14:02 +0200
User-agent: Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu)

On Thu 24 Mar 2016 05:39:22 PM CET, Paolo Bonzini wrote:
> @@ -335,6 +346,11 @@ void throttle_group_config(BlockDriverState *bs, 
> ThrottleConfig *cfg)
>      }
>      throttle_config(ts, tt, cfg);
>      qemu_mutex_unlock(&tg->lock);
> +
> +    aio_context_acquire(bdrv_get_aio_context(bs));
> +    qemu_co_enter_next(&bs->throttled_reqs[0]);
> +    qemu_co_enter_next(&bs->throttled_reqs[1]);
> +    aio_context_release(bdrv_get_aio_context(bs));
>  }

None of the functions in throttle-groups.c acquire the AioContext
because they all assume that the caller is doing it, so we can do the
same here for consistency.

Berto



reply via email to

[Prev in Thread] Current Thread [Next in Thread]