Re: [Qemu-block] [PATCH 2/3] block/qapi: Factor out bdrv_query_bds_stats()

[Kevin Wolf]

Am 02.03.2016 um 17:47 hat Max Reitz geschrieben:
> On 26.02.2016 21:22, Kevin Wolf wrote:
> > The new functions handles the data that is taken from the
> > BlockDriverState.
> > 
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> >  block/qapi.c | 31 ++++++++++++++++++++-----------
> >  1 file changed, 20 insertions(+), 11 deletions(-)
> 
> Reviewed-by: Max Reitz <address@hidden>
> 
> Now that I see s->stats->wr_highest_offset in this function, thus
> piquing my interest in s->stats... How about another patch which makes
> bdrv_query_blk_stats() take the BlockDeviceStats pointer instead of
> BlockStats?

Hm, doesn't work any more after patch 3. Which doesn't necessarily mean
that it's a bad thought, maybe s->device can be set in the caller
instead.

Kevin

pgpYNGZpzye50.pgp
Description: PGP signature