Re: [Qemu-block] [PATCH v2 0/2] move qcow2_invalidate_cache() out of coroutine context

[Denis V. Lunev]

On 02/18/2016 08:17 AM, Amit Shah wrote:
> Can someone from the block team please give this a review?
>
> Thanks,
guys?


> On (Fri) 12 Feb 2016 [09:39:32], Denis V. Lunev wrote:
> > There is a possibility to hit an assert in qcow2_get_specific_info that
> > s->qcow_version is undefined. This happens when VM in starting from
> > suspended state, i.e. it processes incoming migration, and in the same
> > time 'info block' is called.
> >
> > The problem is that qcow2_invalidate_cache() closes the image and
> > memset()s BDRVQcowState in the middle.
> >
> > This operation should not be performed in coroutine context.
> >
> > Changes from v1:
> > - fixed spelling. Eric, thank you for spell checking
> >
> > Signed-off-by: Denis V. Lunev <address@hidden>
> > CC: Paolo Bonzini <address@hidden>
> > CC: Juan Quintela <address@hidden>
> > CC: Amit Shah <address@hidden>
>                 Amit