[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-block] [PATCH v5 08/10] qemu-nbd: don't overlap long option values
From: |
Daniel P. Berrange |
Subject: |
[Qemu-block] [PATCH v5 08/10] qemu-nbd: don't overlap long option values with short options |
Date: |
Tue, 2 Feb 2016 12:57:42 +0000 |
When defining values for long options, the normal practice is
to start numbering from 256, to avoid overlap with the range
of valid values for short options.
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Daniel P. Berrange <address@hidden>
---
qemu-nbd.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index ee91e47..026cf86 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -42,12 +42,12 @@
#include <pthread.h>
#define SOCKET_PATH "/var/lock/qemu-nbd-%s"
-#define QEMU_NBD_OPT_CACHE 1
-#define QEMU_NBD_OPT_AIO 2
-#define QEMU_NBD_OPT_DISCARD 3
-#define QEMU_NBD_OPT_DETECT_ZEROES 4
-#define QEMU_NBD_OPT_OBJECT 5
-#define QEMU_NBD_OPT_IMAGE_OPTS 6
+#define QEMU_NBD_OPT_CACHE 256
+#define QEMU_NBD_OPT_AIO 257
+#define QEMU_NBD_OPT_DISCARD 258
+#define QEMU_NBD_OPT_DETECT_ZEROES 259
+#define QEMU_NBD_OPT_OBJECT 260
+#define QEMU_NBD_OPT_IMAGE_OPTS 261
static NBDExport *exp;
static int verbose;
--
2.5.0
- Re: [Qemu-block] [PATCH v5 02/10] qemu-img: add support for --object command line arg, (continued)
- [Qemu-block] [PATCH v5 05/10] qemu-io: allow specifying image as a set of options args, Daniel P. Berrange, 2016/02/02
- [Qemu-block] [PATCH v5 03/10] qemu-nbd: add support for --object command line arg, Daniel P. Berrange, 2016/02/02
- [Qemu-block] [PATCH v5 04/10] qemu-io: add support for --object command line arg, Daniel P. Berrange, 2016/02/02
- [Qemu-block] [PATCH v5 06/10] qemu-nbd: allow specifying image as a set of options args, Daniel P. Berrange, 2016/02/02
- [Qemu-block] [PATCH v5 08/10] qemu-nbd: don't overlap long option values with short options,
Daniel P. Berrange <=
- [Qemu-block] [PATCH v5 10/10] qemu-io: use no_argument/required_argument constants, Daniel P. Berrange, 2016/02/02
- [Qemu-block] [PATCH v5 09/10] qemu-nbd: use no_argument/required_argument constants, Daniel P. Berrange, 2016/02/02
- [Qemu-block] [PATCH v5 07/10] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2016/02/02
Re: [Qemu-block] [PATCH v5 07/10] qemu-img: allow specifying image as a set of options args, Eric Blake, 2016/02/04