[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH v8 00/15] qemu-img map: Allow driver to return f
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-block] [PATCH v8 00/15] qemu-img map: Allow driver to return file of the allocated block |
Date: |
Mon, 25 Jan 2016 14:37:31 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 25.01.2016 um 03:44 hat Fam Zheng geschrieben:
> v8: Fix patch 15. [Max]
> Add Max's rev-by in patch 1.
>
> v7: Rebase, update patch 1 for two new bdrv_get_block_status_above() callers
> in
> qemu-img.c. [Max]
> Add Max's rev-by in patch 12.
>
> Original cover letter
> ---------------------
>
> I stumbled upon this when looking at external bitmap formats.
>
> Current "qemu-img map" command only displays filename if the data is allocated
> in bs (bs->file) itself, or in the backing chain. Otherwise, it displays an
> unfriendly error message:
>
> $ qemu-img create -f vmdk -o subformat=monolithicFlat /tmp/test.vmdk 1G
>
> $ qemu-img map /tmp/test.vmdk
> Offset Length Mapped to File
> qemu-img: File contains external, encrypted or compressed clusters.
>
> This can be improved. This series extends the .bdrv_co_get_block_status
> callback, to let block driver return the BDS of file; then updates all driver
> to implement it; and lastly, it changes qemu-img to use this information in
> "map" command:
>
>
> $ qemu-img map /tmp/test.vmdk
> Offset Length Mapped to File
> 0 0x40000000 0 /tmp/test-flat.vmdk
>
> $ qemu-img map --output json /tmp/test.vmdk
> [{"length": 1073741824, "start": 0, "zero": false, "offset": 0, "depth":
> 0,
> "file": "/tmp/test-flat.vmdk", "data": true}
> ]
Commented on patches 1, 4 and 11. The rest looks good to me.
Kevin
- [Qemu-block] [PATCH v8 11/15] vmdk: Return extent's file in bdrv_get_block_status, (continued)
- [Qemu-block] [PATCH v8 11/15] vmdk: Return extent's file in bdrv_get_block_status, Fam Zheng, 2016/01/24
- [Qemu-block] [PATCH v8 12/15] block: Use returned *file in bdrv_co_get_block_status, Fam Zheng, 2016/01/24
- [Qemu-block] [PATCH v8 13/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status, Fam Zheng, 2016/01/24
- [Qemu-block] [PATCH v8 14/15] qemu-img: Make MapEntry a QAPI struct, Fam Zheng, 2016/01/24
- [Qemu-block] [PATCH v8 15/15] iotests: Add "qemu-img map" test for VMDK extents, Fam Zheng, 2016/01/24
- Re: [Qemu-block] [PATCH v8 00/15] qemu-img map: Allow driver to return file of the allocated block,
Kevin Wolf <=