[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v4 02/12] fdc: reduce number of pic
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments |
|
Date: |
Wed, 20 Jan 2016 13:30:37 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 |
On 01/19/2016 11:51 PM, John Snow wrote:
> Modify this function to operate directly on FDrive objects instead of
> unpacking and passing all of those parameters manually. Reduces the
> complexity in the caller and reduces the number of args to just one.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> hw/block/fdc.c | 50 ++++++++++++++++++++------------------------------
> 1 file changed, 20 insertions(+), 30 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v4 00/12] fdc: fix 2.88mb floppy diskette support, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 01/12] fdc: move pick_geometry, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments, John Snow, 2016/01/20
- Re: [Qemu-block] [Qemu-devel] [PATCH v4 02/12] fdc: reduce number of pick_geometry arguments,
Eric Blake <=
- [Qemu-block] [PATCH v4 05/12] fdc: Throw an assertion on misconfigured fd_formats table, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 03/12] fdc: add drive type qapi enum, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 04/12] fdc: add disk field, John Snow, 2016/01/20
- [Qemu-block] [PATCH v4 07/12] fdc: Add fallback option, John Snow, 2016/01/20