[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [Qemu-devel] [PATCH v2 09/10] qemu-nbd: use no_argument
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-block] [Qemu-devel] [PATCH v2 09/10] qemu-nbd: use no_argument/required_argument constants |
|
Date: |
Wed, 23 Dec 2015 10:40:30 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/23/2015 10:11 AM, Daniel P. Berrange wrote:
> When declaring the 'struct option' array, use the standard
> constants no_argument/required_argument, instead of magic
> values 0 and 1.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> qemu-nbd.c | 47 ++++++++++++++++++++++++-----------------------
> 1 file changed, 24 insertions(+), 23 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH v2 00/10] Make qemu-img/qemu-nbd/qemu-io CLI more flexible, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 01/10] qom: add helpers for UserCreatable object types, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 03/10] qemu-nbd: add support for --object command line arg, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 04/10] qemu-io: add support for --object command line arg, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 02/10] qemu-img: add support for --object command line arg, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 06/10] qemu-nbd: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 05/10] qemu-io: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 08/10] qemu-nbd: don't overlap long option values with short options, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 09/10] qemu-nbd: use no_argument/required_argument constants, Daniel P. Berrange, 2015/12/23
- Re: [Qemu-block] [Qemu-devel] [PATCH v2 09/10] qemu-nbd: use no_argument/required_argument constants,
Eric Blake <=
- [Qemu-block] [PATCH v2 07/10] qemu-img: allow specifying image as a set of options args, Daniel P. Berrange, 2015/12/23
- [Qemu-block] [PATCH v2 10/10] qemu-io: use no_argument/required_argument constants, Daniel P. Berrange, 2015/12/23